[nemo-qml-plugin-systemsettings] Simplify DBus argument in call chang… #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing GPS flight mode.
pvuorela
reviewed
May 17, 2022
| @@ -515,7 +515,7 @@ void LocationSettings::setGpsFlightMode(bool flightMode) | |||
| if (d->m_gpsTechInterface) { | |||
| QDBusReply<void> reply = d->m_gpsTechInterface->blockingCall("SetProperty", | |||
| PoweredPropertyName, | |||
| QVariant::fromValue<QDBusVariant>(QDBusVariant(QVariant::fromValue<bool>(!flightMode)))); | |||
| QVariant::fromValue<bool>(!flightMode)); | |||
There was a problem hiding this comment.
Didn't test, but wouldn't this now call SetProperty with bool as parameter type instead of dbus variant bool?
There was a problem hiding this comment.
Good point, I need to test. Maybe that's the reason of such complex construction to pass a boolean value in the end.
There was a problem hiding this comment.
Long time. Could just close the pr maybe?
|
Invalid change, as mentioned by @pvuorela , closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ing GPS flight mode.
Nothing serious but while searching for why my GPS was in flight mode, I notice this interesting construction. I may miss something, but I think it can be simplified a bit.