Hide external libraries (except connman-qt5) from public api. JB#61655 #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Has been the qt default for long, and definitely no need to define it twice.
Should be a private class by name but yet it's included in the public ones and installed. Here just moved the private data to private class, the private methods don't refer to any external library except Qt.
…ed libs. JB#61655
mlehtima
approved these changes
Mar 1, 2024
LaakkonenJussi
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pimplified some classes which where exposing external library content on the headers in order not to require depending project a) linking also to those libraries, and b) requiring the external library header files to be present when compiling them (that seemed working by accident except for nemo-dbus).
Sorry for code churn here, but it's mostly just moving stuff around and sprinkling some d_ptr-> here and there.