Move vpn model to nemo.connectivity. JB#61656 #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not used since commit e1f125e
…tivity. JB#61656 Connectivity should be a good home for this and removing it here allows to remove connman-qt5 from the pkgconfig requirements. As a result the projects linking against the system settings library won't need to be linked against connman-qt5.
Would have removed qml dependency form the whole library, but DiskUsage is using QJSValue for callbacks. Perhaps that could be removed by now or moved out of the c++ library, but that's for next step.
LaakkonenJussi
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets rid of connman-qt5 dependency added to all c++ projects linking against systemsettings library.
While at it removed also unnecessary qml dependency on alarmtonemodel. The qml dependency could be otherwise removed from the library, but there's still the 2019 deprecated DiskUsage using it. I can check afterwards on removing that too.