Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nemo-qml-plugin-thumbnailer] Replace separate video thumbnailer package. JB#57202 #3

Merged
merged 1 commit into from Jan 27, 2022

Conversation

pvuorela
Copy link
Contributor

Commit 9695503 removed the use of separate video thumbnailer .so
and started executing a separate executable.

-> Use Provides: for the functionality that's required on some packages,
and here depend on thumbnailerd that includes the executables.

@pvuorela
Copy link
Contributor Author

@Tomin1 @spiiroin

Copy link

@spiiroin spiiroin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense, package builds and installs.

However already installed nemo-qml-plugin-thumbnailer-qt5-libav that supposedly also provides nemo-qml-plugin-thumbnailer-qt5-video is left on device - does it matter?

@pvuorela
Copy link
Contributor Author

However already installed nemo-qml-plugin-thumbnailer-qt5-libav that supposedly also provides nemo-qml-plugin-thumbnailer-qt5-video is left on device - does it matter?

Let's actually provide and conflict with that so we get rid of the old packages.

…age. JB#57202

Commit 9695503 removed the use of separate video thumbnailer .so
and started executing a separate executable.

-> Use Provides: for the functionality that's required on some packages,
and here depend on thumbnailerd that includes the executables.
@pvuorela pvuorela merged commit a43a7cb into master Jan 27, 2022
@rainemak rainemak deleted the provide_video branch January 27, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants