[perl] Explicitly depend on pkgconfig(libcrypt). JB#54931 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saukko
reviewed
Aug 25, 2021
| @@ -91,7 +91,9 @@ Patch15: errno3-lib-h2ph.t-to-test-generated-t-_h2ph_pre.ph.patch | |||
| # Update some of the bundled modules | |||
| # see http://fedoraproject.org/wiki/Perl/perl.spec for instructions | |||
|
|
|||
| BuildRequires: db4-devel, zlib-devel, bzip2-devel | |||
There was a problem hiding this comment.
Also could use pkgconfig(bzip2) while at it, right?
saukko
approved these changes
Aug 25, 2021
|
@saukko commented on this pull request.
> @@ -91,7 +91,9 @@ Patch15:
> errno3-lib-h2ph.t-to-test-generated-t-_h2ph_pre.ph.patch
# Update some of the bundled modules
# see http://fedoraproject.org/wiki/Perl/perl.spec for instructions
-BuildRequires: db4-devel, zlib-devel, bzip2-devel
Also could use pkgconfig(bzip2) while at it, right?
Our version of bzip2 has no pkgconfig file so no.
|
xfade
approved these changes
Aug 25, 2021
perl depends on pkconfig(libcrypt) for the crypt function but it was not included. This makes the build fail when pkconfig(libcrypt) is not bundled in the glib-devel package. Signed-off-by: Björn Bidar <bjorn.bidar@jolla.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perl depends on pkconfig(libcrypt) for the crypt function but it was
not included. This makes the build fail when pkconfig(libcrypt) is not bundled in the glib-devel package.