[qtdocgallery] Adjust declarative document gallery life-cycle. JB#59060 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spiiroin
approved these changes
Nov 16, 2022
The Q_GLOBAL_STATIC gets deleted at exit and by backtrace that seems too late for deleting the tracker connection. So instead couple the life-cycle with the QCoreApplication instance. The QML content shouldn't outlive that.
pvuorela
force-pushed
the
adjust_declarative_docgallery_lifecycle
branch
from
676d2b8
to
391a4dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Q_GLOBAL_STATIC gets deleted at exit and by backtrace that seems too late for deleting the tracker connection.
So instead couple the life-cycle with the QCoreApplication instance. The QML content shouldn't outlive that.
@spiiroin @Tomin1 @llewelld