[qtmozembed] Fix text input with xt9. JB#56870 #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think title of this should be called "Fix text prediction input with xt9" |
|
Modified to use textevent only if previous input had preedit, so this change should only affect devices with xt9. |
rainemak
reviewed
Jan 18, 2022
src/qmozview_p.cpp
Outdated
| mView->SendTextEvent(event->commitString().toUtf8().data(), event->preeditString().toUtf8().data(), event->replacementStart(), event->replacementLength()); | ||
| } else { | ||
| mView->SendKeyPress(0, 0, charCode); | ||
| mView->SendKeyRelease(0, 0, charCode); | ||
| } | ||
|
|
rainemak
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QMozViewPrivate::touchEvent issues the commit when screen is tapped and that sent the extra keypress with xt9. I didn't notice any problems in the browser test pages with this and also https://webk.telegram.org works.