Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split and fix tst_searchengine #41

Merged
merged 2 commits into from Feb 18, 2022
Merged

Split and fix tst_searchengine #41

merged 2 commits into from Feb 18, 2022

Conversation

rainemak
Copy link
Member

Contains two commits

  • Wait engine to load in initTestCase
  • Split checkDefaultSearch of tst_searchengine to three

There are separate test functions for adding search engine, changing default,
and doing a search.

The dedicated test.xml is updated so that url is like qmoztest. This
way we can more easily compare url value. Actual search result is
irrelevant.

Further, test_003_searchFromWeb is skipped if there's no network
connection as it would time out easily when trying to do http get
without network to none existing service.

Requires:
sailfishos/embedlite-components#92

Whilst running tests locally noticed that test runner looks up installed search engines always from /home/defaultuser/.local/share/org.sailfishos/browser/searchEngines regardless of the active profile. The should be coming from here: https://github.com/sailfishos/gecko-dev/blob/master/embedding/embedlite/utils/DirProvider.cpp#L56 and there should be simple fix. Building engine with a fix applied and will open that PR shortly.

There are separate test functions for adding search engine, changing default,
and doing a search.

The dedicated test.xml is updated so that url is like qmoztest. This
way we can more easily compare url value. Actual search result is
irrelevant.

Further, test_003_searchFromWeb is skipped if there's no network
connection as it would time out easily when trying to do http get
without network to none existing service.
@rainemak
Copy link
Member Author

This will fix the profile directory and look up. Following pref will dump look up path when there is an open search xml in the directory.

user_pref("browser.search.log", true);

@rainemak rainemak merged commit d536219 into master Feb 18, 2022
@rainemak rainemak deleted the jb57275 branch February 18, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants