Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains two commits
There are separate test functions for adding search engine, changing default,
and doing a search.
The dedicated test.xml is updated so that url is like qmoztest. This
way we can more easily compare url value. Actual search result is
irrelevant.
Further, test_003_searchFromWeb is skipped if there's no network
connection as it would time out easily when trying to do http get
without network to none existing service.
Requires:
sailfishos/embedlite-components#92
Whilst running tests locally noticed that test runner looks up installed search engines always from /home/defaultuser/.local/share/org.sailfishos/browser/searchEngines regardless of the active profile. The should be coming from here: https://github.com/sailfishos/gecko-dev/blob/master/embedding/embedlite/utils/DirProvider.cpp#L56 and there should be simple fix. Building engine with a fix applied and will open that PR shortly.