Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[qtmozembed] Avoid sending orientation signal on scene changes. Fixes JB#57688 #42

Merged
merged 1 commit into from
Mar 7, 2022
Merged

[qtmozembed] Avoid sending orientation signal on scene changes. Fixes JB#57688 #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/quickmozview.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,12 @@ void QuickMozView::itemChange(ItemChange change, const ItemChangeData &data)
if (data.window) {
connect(data.window, &QQuickWindow::contentOrientationChanged, this, &QuickMozView::updateOrientation);

// Update the orientation, but without emitting an orientationChanged signal
llewelld marked this conversation as resolved.
Show resolved Hide resolved
// Emitting the signal at this point will cause a SIGSEGV because
// the QML item isn't ready to be activated just yet, see JB#57688
blockSignals(true);
updateOrientation(data.window->contentOrientation());
blockSignals(false);
}
}
QQuickItem::itemChange(change, data);
Expand Down