Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[packaging] Don't package unused la files. JB#55344 #2

Merged
merged 1 commit into from Jan 30, 2024
Merged

Conversation

Thaodan
Copy link
Contributor

@Thaodan Thaodan commented Jan 8, 2024

No description provided.

@mkosola
Copy link
Contributor

mkosola commented Jan 8, 2024

Hmm, I think you need to rm those files in spec, otherwise build will will stop on unpackaged files?

@pvuorela
Copy link
Contributor

pvuorela commented Jan 22, 2024

I guess what is left unsaid is that meego-rpm-config is getting made remove these files, right?

rpm is removing those but our config which scripts are called in %__os_install_post.
RPM %__os_install_post is overridden as intended
(even thou there are some legacy scripts still in there but that's for later).

In that case it could be worth a comment in the commit and this would effectively depend on the macro changes.

Applies to some other similar PRs too.

I added a comment that explains that rpm takes care of these.

Previously these were packaged although they were not used.
Rpm will take care of cleaning those up for us:
rpm-software-management/rpm@e0de325

Reference: sailfishos/rpm#14, sailfishos/meego-rpm-config#6
Signed-off-by: Björn Bidar <bjorn.bidar@jolla.com>
@Thaodan Thaodan merged commit 2f86c98 into mer-5.6 Jan 30, 2024
@mlehtima mlehtima deleted the no_la branch April 22, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants