Avoid rounded corners on toolbar and action popups #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap overlong lines, add some empty lines after ids, move some operators to start of the lines as per coding conventions, etc.
Confusing when there's Background in this repository but then another component with same name from an imported module. Import with name to avoid confusion.
Double toolbar naming seems like a leftover from the times with different UI. Also externally this is already secondary tools so should be simpler calling it that way also internally.
Adding some extra paddings to toolbars on bottom and the placements of the action popups.
spiiroin
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanups in separate commits and last a commit to add some extra paddings if corner rounding requires such.