Correct search bar progress not filling-up toolbar height. Contributes TJC#212568

[dcaliste]

As reported by @rozgwi on TJC, the search progress bar was not filling properly up the toolbar height. I'm also pushing an additional commit to correct the page indicator not highlighted on press.

@pvuorela and @jpetrell, during the redesigned, you choose to remove BackgroundItem from toolbar items. I guess it's by design to use only IconButton there. I've one question though: the search icon is still a BackgroundItem and when pressed, it is highlighted with a solid coloured rectangle, while all other icon buttons are not. Should we correct this inconsistency by making SearchBarItem to inherit IconButton instead of BackgroundItem ? Or should we add BackgroundItem to all other IconButtons ?

[pvuorela]

For search item background, I'd maybe just remove it. Also to search opened state has strange fulll width background and icon colored.

[dcaliste]

For search item background, I'd maybe just remove it.

Ok, done. At the beginning, I try to make SearchBarItem to inherit from IconButton, but since it has a lot more when expanded, I simply transform the BackgroundItem into a plain Item and adjusted a bit the signals and properties. I think, it's safer, not to introduce regression like that, than trying to make a IconButton being able to cope with the additional TextField and close icon when expanded.

[pvuorela]

LGTM, thanks!