Exit on hal errors during initialization #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In theory sensors API version 1 should provide batch() method and older versions should provide setDelay() method. But there are hal libraries that differ from that and/or report incorrect version information - which then can lead to crashes when calls to null function pointers are made. Check availability of both batch() and setDelay() methods. Use API version information to decide which one to try first, and use fallback error code for diagnostic logging if neither method is available. Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
At what stage of bootup sensors can be accessed via android hal varies from one device to another. If sensorfwd is started too early, it can end up finding no sensors and still remain running without serving any useful purpose. Make sensorfwd exit if sensor hal probing fails in ways where no sensible operation is not going to be possible. Rate limit restart attempts by systemd to allow droid hal init some time to reach state where sensors might be available. Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
mlehtima
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.