Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dbus] Change value type of domainConfig functions to a{sv} to match QVariantMap #2

Merged
merged 1 commit into from Aug 11, 2021
Merged

[dbus] Change value type of domainConfig functions to a{sv} to match QVariantMap #2

merged 1 commit into from Aug 11, 2021

Conversation

CODeRUS
Copy link
Contributor

@CODeRUS CODeRUS commented Jun 23, 2021

…QVariantMap

@monich
Copy link
Member

monich commented Jul 2, 2021

Wouldn't that break compatibility with the code which keeps using the old signature?

@CODeRUS
Copy link
Contributor Author

CODeRUS commented Jul 2, 2021

Wouldn't that break compatibility with the code which keeps using the old signature?

function expect QVariantMap value anyway, but announced in d-bus as expecting QString map. Fixes introspection.

@monich
Copy link
Member

monich commented Jul 2, 2021

function expect QVariantMap value anyway, but announced in d-bus as expecting QString map. Fixes introspection.

Makes sense then!

@abranson abranson merged commit 03138a8 into sailfishos:master Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abranson abranson abranson approved these changes

@okodron okodron okodron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@CODeRUS @monich @abranson @okodron