Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[transferengine] Add MediaItem::FileDescriptor and related features. … #1

Closed
wants to merge 1 commit into from

Conversation

blammit
Copy link
Contributor

@blammit blammit commented Jun 16, 2021

…JB#54169 JOLLA-126

This allows resources to be added using a file descriptor.

…JB#54169 JOLLA-126

This allows resources to be added using a file descriptor.
@pvuorela
Copy link
Contributor

Is this compatible with the transfer restart action which many transfer interface claim to support? Looks like that path fetches the transfer data from the database and you can't really store file descriptors there. If we assume that the transfer engine has access to all the transferred files, do we need much changes on this front? The most problematic case should be app getting the shared files, which skips the transfer api, right?

@blammit
Copy link
Contributor Author

blammit commented Jun 22, 2021

Yes I'm not sure what we want to do with the restart action. We could still support it while sailfish-share is open and the file descriptor is available, but then it's inconsistent if only supported at certain times.

Currently the file descriptor mechanism is only technically required in the app cases (email, MMS), since the transfer engine can access other files, as you mentioned, but I implemented it there as well for consistency, and because I'm not sure what we're planning for permission changes later on. If we prefer, we can restrict the file descriptor implementation to the app cases for now.

@pvuorela
Copy link
Contributor

Ok, as commented elsewhere, perhaps we skip this part now.

@blammit
Copy link
Contributor Author

blammit commented Jun 23, 2021

No longer necessary, as discussed.

@blammit blammit closed this Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants