Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[udisks2] Update to version 2.9.4. JB#55971 #3

Merged
merged 3 commits into from Nov 18, 2021
Merged

[udisks2] Update to version 2.9.4. JB#55971 #3

merged 3 commits into from Nov 18, 2021

Conversation

Thaodan
Copy link
Contributor

@Thaodan Thaodan commented Nov 2, 2021

No description provided.

@Thaodan Thaodan force-pushed the jb55971 branch 10 times, most recently from e77069b to c28d343 Compare November 9, 2021 12:26
@Thaodan
Copy link
Contributor Author

Thaodan commented Nov 9, 2021

.

@Thaodan Thaodan force-pushed the jb55971 branch 2 times, most recently from b169486 to 13b1aa1 Compare November 9, 2021 13:02
@pvuorela
Copy link
Contributor

pvuorela commented Nov 9, 2021

Could you also remove "BuildRequires: gnome-common". To my knowledge this is the last project that needed it and the newer versions have gotten rid of the dependency.

Copy link

@okodron okodron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BuildRequires: libxslt can be replaced with BuildRequires: pkgconfig(libxslt).

Copy link

@okodron okodron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BuildRequires: intltool exists twice.

Also spec contains both BuildRequires: pkgconfig(systemd) and BuildRequires: systemd.

@Thaodan Thaodan force-pushed the jb55971 branch 3 times, most recently from 2797b1b to f528565 Compare November 9, 2021 14:56
rpm/udisks2.spec Outdated Show resolved Hide resolved
@Thaodan Thaodan force-pushed the jb55971 branch 2 times, most recently from 89e46fb to 684bb28 Compare November 11, 2021 13:44
rpm/udisks2.spec Outdated Show resolved Hide resolved
@pvuorela
Copy link
Contributor

Still having that obsolete BuildRequires

@Thaodan Thaodan changed the title WIP: [udisks2] Update to version 2.9.4. JB#55971 [udisks2] Update to version 2.9.4. JB#55971 Nov 17, 2021
Copy link
Member

@Tomin1 Tomin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Thaodan Thaodan merged commit 6ba52ca into master Nov 18, 2021
@rainemak rainemak deleted the jb55971 branch January 26, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants