Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[packaging] Remove static libs. Install to /usr. JB#55344 #7

Merged
merged 1 commit into from Mar 27, 2024

Conversation

Thaodan
Copy link
Contributor

@Thaodan Thaodan commented Jan 8, 2024

No description provided.

@@ -332,7 +312,7 @@ done
%pre -n uuidd
getent group uuidd >/dev/null || groupadd -r uuidd
getent passwd uuidd >/dev/null || \
useradd -r -g uuidd -d /var/lib/libuuid -s /sbin/nologin \
useradd -r -g uuidd -d /var/lib/libuuid -s %{_sbindir}/nologin \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If uuidd package was previously installed, user uuidd was already created with /sbin/nologin as shell. In that case we should probably change the shell to point to /usr/sbin/nologin here. Then again, I don't think we actually use uuidd anywhere or do we? Could we perhaps just get rid of the package?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I added a symlink before we have a symlink from /usr/bin to /bin after we have fully done the UsrMove.

Copy link
Member

@vigejolla vigejolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer having the unrelated changes (remove static libs, install to /usr) in separate commits.

@Thaodan
Copy link
Contributor Author

Thaodan commented Jan 21, 2024

I would prefer having the unrelated changes (remove static libs, install to /usr) in separate commits.

I tested the changes together in a world rebuild. None of the changes broke any builds.
None of the script do relay on calling those programs without path.

@mkosola
Copy link

mkosola commented Jan 22, 2024

Please also update some device and test upgrade path before merge this.

@Thaodan Thaodan force-pushed the static_libs branch 2 times, most recently from 4309a38 to e3bba4b Compare March 27, 2024 17:44
Signed-off-by: Björn Bidar <bjorn.bidar@jolla.com>
@Thaodan Thaodan merged commit 44baf2a into master Mar 27, 2024
@mlehtima mlehtima deleted the static_libs branch April 22, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants