New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[packaging] Remove static libs. Install to /usr. JB#55344 #7
Conversation
@@ -332,7 +312,7 @@ done | |||
%pre -n uuidd | |||
getent group uuidd >/dev/null || groupadd -r uuidd | |||
getent passwd uuidd >/dev/null || \ | |||
useradd -r -g uuidd -d /var/lib/libuuid -s /sbin/nologin \ | |||
useradd -r -g uuidd -d /var/lib/libuuid -s %{_sbindir}/nologin \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If uuidd
package was previously installed, user uuidd was already created with /sbin/nologin
as shell. In that case we should probably change the shell to point to /usr/sbin/nologin
here. Then again, I don't think we actually use uuidd
anywhere or do we? Could we perhaps just get rid of the package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I added a symlink before we have a symlink from /usr/bin
to /bin
after we have fully done the UsrMove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer having the unrelated changes (remove static libs, install to /usr) in separate commits.
I tested the changes together in a world rebuild. None of the changes broke any builds. |
Please also update some device and test upgrade path before merge this. |
4309a38
to
e3bba4b
Compare
Signed-off-by: Björn Bidar <bjorn.bidar@jolla.com>
No description provided.