Remove unimplemented methods. Fixes JB#55332 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blammit
approved these changes
Aug 31, 2021
Unused parameters and DEBUG_T was confusing qt formatting with printf formatting. And sendingStates are enums, not strings.
pvuorela
force-pushed
the
remove_unimplemented
branch
from
8345d5f
to
6506ba1
Compare
|
Checking https://github.com/sailfishos/voicecall/pull/2/files I noticed actually the parameter to debug was also wrong, it's enum not string -> qprintable not valid. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing methods mentioned in
#3
@blammit