Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for text-only mode #15

Merged
merged 3 commits into from
May 7, 2024

Conversation

spiiroin
Copy link
Contributor

@spiiroin spiiroin commented May 6, 2024

No description provided.

Silencing compilation warnings from text_blend() without thinking
broke it altogether. Make an another attempt at it.

Add support for multi-line text and some rudimentary control characters.
And related to this, do not stop processing at the 1st out of screen
character as the next line might be on screen again.

Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
@spiiroin spiiroin requested review from Thaodan and mlehtima May 6, 2024 11:32
@spiiroin spiiroin self-assigned this May 6, 2024
Copy link

@Thaodan Thaodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

If no graphics files are given, text is not shown at all.

Add render callback that deals with text only situations.

Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
As text position can't be changed and actual screen estate required by
images varies from one device to another, graphics can end up obscuring
the text.

Switch rendering order so that text is drawn on top of image and not
the other way around.

Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
@spiiroin
Copy link
Contributor Author

spiiroin commented May 7, 2024

As more changes are needed elsewhere, removed "Fixes" type bug reference from commit

@spiiroin spiiroin merged commit 01f3e18 into sailfishos:master May 7, 2024
@spiiroin spiiroin deleted the jb61382_text_and_font branch May 7, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants