Improve Purchase and PurchaseItem models with addition of user agent and images #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add support for images in PurchaseItem and centralize the logic of creating a new image entry that exists in Content - Minor cosmetic fix to add generic type on tags field
…nflict in today's environment - Update gson to 2.8.6 - Update httpclient to 4.5.12 and httpcore to 4.4.13 - Update slf4j to 1.7.30 - For internal use, update junit to 4.13, mockito to 3.4.6 and all maven plugins - Fix unit test to have correct mocking and remove deprecated usages
brndnwng
approved these changes
Aug 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds missing support of user agent in purchase as well as images in PurchaseItem
To avoid duplication, the logic to create a new image entry has been centralized in SailthruUtils