Do not throw exception for successful http codes and remove redundant cases #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harmannz
force-pushed
the
pt-694-add_created_http_code
branch
from
85c1c1b
to
6ec3410
Compare
|
Hey, please add reviewers you see fit. |
|
Going to put this PR to the back burner as it contains refactoring that may require approval from Matt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UnAuthorizedException and ResourceNotFoundException are redundant. They are never thrown by the handleResponse method.
They can technically be thrown if specificity is required. E.g.
throw new UnAuthorizedException(statusCode, "bad gateway", (Map<String, Object>)parseObject);If not required, then I am happy to delete those exception classes:
https://github.com/sailthru/sailthru-java-client/tree/master/src/main/com/sailthru/client/exceptions