Additional video options #420
Conversation
Adding in the ability to do 2-pass encoding Allowing user to disable video resizing Allowing user to force a video encode even within the same codec
Codecov Report
@@ Coverage Diff @@
## master #420 +/- ##
==========================================
+ Coverage 86.49% 86.63% +0.14%
==========================================
Files 22 22
Lines 1799 1818 +19
==========================================
+ Hits 1556 1575 +19
Misses 243 243
Continue to review full report at Codecov.
|
sigal/templates/sigal.conf.py
Outdated
|
|
||
| # Set this to false if no resizing is desired on the video. This overrides | ||
| # the video_size option. | ||
| # video_resize = True |
There was a problem hiding this comment.
Maybe allow video_size = None to disable resizing, which would remove one configuration option ?
sigal/video.py
Outdated
| logger.debug('Video size: %i, %i -> %i, %i', w_src, h_src, w_dst, h_dst) | ||
| return {'src': (w_src, h_src), 'dst': (w_dst, h_dst)} |
There was a problem hiding this comment.
Why not putting this directly in get_resize_options to avoid the dict packing/unpacking ? I think it's the only place where it is used.
| final_second_pass_options = _get_empty_if_none_else_variable( | ||
| second_pass_options) + resize_opt | ||
| generate_video_pass(converter, source, | ||
| final_second_pass_options, outname) |
There was a problem hiding this comment.
So when doing 2-pass encoding the idea is that ffmpeg will create a temp file in the first pass and find it when doing the second pass right ?
There was a problem hiding this comment.
That is correct, yes. I don't believe there is a way to change the filename from the default "ffmpeg2pass-0.log"
Using video_size = None to prevent resizing instead of another option Eliminating pointless method for just getting resize_dimensions
|
Thanks for the recommendations, both have been pushed. Would you like me to squash this commit as well? |
|
Oups sorry I forgot to merge your PR before mine (#421), so now you get some conflicts :( |
|
No problem, conflict should be resolved. Merge whenever! Thanks |
|
Thanks! |
Adding in the ability to do 2-pass encoding
Allowing user to disable video resizing
Allowing user to force a video encode even within the same codec