Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Max-Unit-Option #4

Merged
merged 2 commits into from
Aug 6, 2020
Merged

Added Max-Unit-Option #4

merged 2 commits into from
Aug 6, 2020

Conversation

renky
Copy link
Contributor

@renky renky commented Jul 29, 2020

Possibility to set a maximum unit for the Filter, e.G. if you want to show 1000GB instead of 1TB
Usefull for kind of lists where all values should be shown as max GB and some of them extend the 1000.

Added Max Unit option
Added option to set a maximal unit
@sainf sainf merged commit 3038a5e into sainf:master Aug 6, 2020
@sainf
Copy link
Owner

sainf commented Aug 6, 2020

Hi.

That's a nice option!

But latter on I'll probably add Intl.NumberFormat to "prettify" the result ( 10000 Kib or 10.000 Kib)...

Thanks!

@renky
Copy link
Contributor Author

renky commented Aug 6, 2020

No Prob

for other numbers and currencies I use i18n with Nuxt and localisation, the Numbers are then formated in a good manner using the $n() function. I already thought about a possibility to combine this, but didn't find a proper solution. So it might really make sence to add a number-format-option...

Could you please publish the new version to npm? Thanks in advance...

@sainf
Copy link
Owner

sainf commented Aug 6, 2020

Updated in npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants