-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color look a bit washed #6
Comments
What I don't understand is why But it needs to be tweaked indeed, I made a slight adjustment to it: What is your vscode version? Have you installed any syntax extensions that might affect the javascript syntax highlighting? This theme is currently only optimized for built-in js syntax highlighting. |
I dont know why is different from your screenshot. Im using JavaScript ES6 Snippet and Babel JavaScript extension. My VS Code version is 1.40.0 . |
I've tried mgmcdermott.vscode-language-babel, it reproduced. Sorry but I won't optimize this syntax extension, because I think it's very bad. This is the built-in js syntax highlighting: As you can see, in In vscode, I suggest you uninstall this extension and use build-in js syntax highlighting instead, microsoft has done a very great job in js syntax highlighting. The build-in js syntax highlighting is logical and accurate, and every element can be highlighted. |
Thanks for response and solution from you. You can check palette in here. |
Thanks for your link. I have tried to use existing material palettes directly, but the effect is not good. Many material palettes are mainly designed for UI colors instead of foreground colors, so there are some very serious problems when using as foreground colors. To sum up, they're not eye-friendly at all. Please forgive me for saying so straightforward, but this is the truth. The current color palette has been carefully adjusted many times based on the original gruvbox and has been tested on several devices, and works very well with redshift and f.lux . But I think it is currently far from perfect, there might be some adjustments in the future. If you have any ideas or suggestions, welcome to share them in #11. |
Im trying this theme, but when opening JS files and some HTML file, this syntax coloring looks a bit washed. So it can't be distinguished from other method or object in it. Maybe the coloring needs more vivid or vibrant colors.
You can take a look on screenshot below.
![Screenshot_2019-11-15_14-36-10](https://user-images.githubusercontent.com/11639412/68925444-a364f900-07b5-11ea-8644-5cc88e44aa0c.png)
The text was updated successfully, but these errors were encountered: