More Readable Color for Function Call ?

[GulajavaMinistudio]

Hello, thanks for good theme. Recently, i try this theme in one of our project with Vue JS with Vue CLI in VS Code. But it resulted, green color for function name is not easy readable. You can take a look in this screenshot.

This is for your Gruvbox Material Theme

Compare it with other theme, such as Gruvbox Original

Or with Monokai Pro theme

As you can see, your theme with Green color for function name in "methods" in Vue Component look not good and not easy readable. Maybe you can change this color for more green or more vivid green color, so it easy readable ?

[sainnhe]

I haven't optimize vue for this theme yet, I'll do that later.

[sainnhe]

Which syntax highlighting extension are you using? I've tried both jcbuisson.vue and liuji-jim.vue but still cannot reproduce.

[sainnhe]

This issue may be duplicated with #6.

I have to say that I still keep my point, Babel JavaScript is very bad. Microsoft has done a very great job on javascript syntax highlighting which is buildin in vscode, but this extension makes things terrible, I think not installing it is better than installing it.

I once considered setting gruvbox-material to conflict with this extension, but in the end I decided to remind users not to install this extension in the README.

Still, I compromised. A theme extension should do its best to be compatible with the syntax extensions, no matter how bad the syntax extensions are. I've basically optimized this extension via 326143d.

[GulajavaMinistudio]

Oh I'm sorry, I'm using Babel JavaScript syntax highlighting too, I need this extension for other project that using React. Maybe i should disabled it when using your theme. Thank you for workaround

[sainnhe]

You don't need to disable it now, this problem should be fixed. You can update this theme and get it a try.

[GulajavaMinistudio]

Thank you, i have been updated gruvbox material extension, and this works better than before when using in Vue JS Project. Now this theme is more readable color now.

You can close this issue, as it solved.