Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include type definitions directly in the package #335

Closed
pbadenski opened this issue Sep 6, 2021 · 2 comments · Fixed by #354
Closed

Include type definitions directly in the package #335

pbadenski opened this issue Sep 6, 2021 · 2 comments · Fixed by #354

Comments

@pbadenski
Copy link

Revisiting #92 reported back in 2015.

A lot has changed since 2015:

  • TypeScript gained massive popularity and is no longer a "bleeding edge technology"
  • both mongodb and mongoose incorporated typescript definition files in their repository

It's proving quite difficult for the users to have type definitions managed separately in DefinitelyTyped repo (see #327, #304, #332). For us it's a challenge each time we need to upgrade mongodb and mongoose dependencies - as the external types lag behind the actual updates of these libraries.

Following mongodb and mongoose - could I suggest including type definitions as part of this repo?

@saintedlama
Copy link
Owner

Would definitely merge that. Also thinking about rewriting the module in typescript to get the types generated. Any help appreciated.

@pbadenski
Copy link
Author

As pull request is concerned - for the initial step would you be fine if I just move types from DefinitelyTyped to this project? Both are MIT licensed so there's no problem here.

vkarpov15 added a commit to vkarpov15/passport-local-mongoose that referenced this issue May 16, 2022
saintedlama pushed a commit that referenced this issue May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants