-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update mongoose #370
Conversation
I think this approach is feasible and then in a next step remove callback support and use async/await consistently. I updated the main branch to exclude node 12 from supported versions and adding node 18 to the test matrix. Could you merge main into this branch and check if the tests are green? |
@saintedlama, I have rebased on |
Hey, I need to approve the action run for the PR. Did it right now... |
Ready to release? I'll make it a major update because of mongoose 7 |
Sounds good to me! |
Thanks for the PR! New version released to npm 🎉 |
Thank You All for the update |
This PR updates Mongoose to v7 where callback support has been dropped. It should fix #369 with minimal changes:
Document.save(cb)
withDocument.save().then(document => cb(null, document)).catch(cb)
Query.exec(cb)
withQuery.exec().then(document => cb(null, document)).catch(cb)
Is this a reasonable approach or would you want to remove callback support from the plugin methods, too?