Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add script for github and npm release #25

Closed
ismarslomic opened this issue Jul 4, 2015 · 4 comments
Closed

Add script for github and npm release #25

ismarslomic opened this issue Jul 4, 2015 · 4 comments
Labels
enhancement

Comments

@ismarslomic
Copy link
Collaborator

We need consistent way of releasing new versions in github and npm.
ismarslomic added a commit to ismarslomic/restify-mongoose that referenced this issue Jul 4, 2015
@ismarslomic
saintedlama#25 added contributing docs and release procedures to auto…
9cc586f 
…mate git and npm releases
@ismarslomic ismarslomic mentioned this issue Jul 4, 2015
Merged
@saintedlama
Copy link
Owner

Approach is fine. We could make things a bit simpler:

  • Add npm-release as a dev dependency
  • Add release script to npm scripts
  • Point out that npm run release does the release

A simple npm install should do it since istanbul and so on are dev dependencies. I will need to rework the npm cover script a bit to emit an html report but thats fine.

These dependencies are not needed on the dev machine - only travis and travis installs these dependencies via .travis:

  • coveralls
  • mocha-lcov-reporter

@saintedlama
Copy link
Owner

Will merge the pull request and do some changes...

@ismarslomic
Copy link
Collaborator Author

Good points!

@ismarslomic
Copy link
Collaborator Author

Fixed in 9c514bb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@saintedlama @ismarslomic