Allow transformation for insert & update [Discussion]

[djensen47]

This is what I'm working on now. Actually, it's done, I just need to write the tests.

Resource.prototype.insert = function (transform) {
  var self = this;
  var emitInsert = emitEvent(self, 'insert');

  return function(req, res, next) {
    if (transform && typeof transform === 'function') {
      transform(req, res);  
    }
    self.Model.create(req.body, function (err, model) {
      if (err) {
        return onError(err, next);
      }

      res.header('Location', req.url + '/' + model._id);
      res.send(200, model);

      emitInsert(model, next);
    });
  };
};

The idea is that sometimes on an insert or update, you need to modify the data that will be saved. Specifically, an authenticated user POSTing a new note shouldn't have to pass in their own id if we already have it on every request. Thus the transform function.

I wanted to run this by you before I finished the tests and submitted a pull request.

[saintedlama]

I guess we should make the transform callback aware so that we not only

transform(req, res); 

but

transform(req, res, function(err, transformedObj) {
  //...
});

This would not require transform to manipulate the body and transform itself could use some async functions. This could be solved in code like other functionality that uses async to handle these functions.

Thoughts?

[djensen47]

Oops, I though I responded. I think something like beforeSave would be more appropriate. Otherwise, yes, making it part of the async.waterfall makes a lot of sense.

[djensen47]

See Pull Request #10

[djensen47]

I'm going to re-open until the pull request is accepted.