Update version, add new method to return meta string #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New method lets other classes grab the meta name so that if it is updated in the future, it will continue to work. Rename some of the params in "manage_users_column_content" to match those given in the wordpress docs: - https://developer.wordpress.org/reference/hooks/manage_users_custom_column/ Currently, downloading the plugin from wpackagist doesn't return the version of the plugin with the return statement in manage_users_column_content. Hoping that updating the version will fix that.
This was referenced Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request makes a few very small changes, and then increments the version for a patch release.
manage_users_column_contentto match WordPress docsThis is a proposed change -- happy to modify any of it.
new method to return meta key
I am using this plugin for another project where we want to be able to disable users who don't log in for a set amount of time. This plugin has all the functionality we need to enable/disable accounts, but we are copying and pasting the meta key string, which means it would all break if this plugin changed the meta key string in the future.
We can live without this method but it seems fairly innocuous, so I figured it would be an easy PR to add it.
update version
When you download this plugin from the WordPress directory (using "Download"), you don't get the
return $empty;statement inmanage_users_column_content. I think it's because the version wasn't bumped when that change went in: https://github.com/saintsystems/disable-user-login/pull/3/filesUpdated to
1.3.2because all the changes are very minor.change parameter names in
manage_users_column_contentI changed the parameter names in
manage_users_column_contentto match what's on the documentation for themanage_users_custom_columnhook.fix up a couple of comments
I was initially thrown for a loop when reading the comment above the custom "enable user" action hook because it claimed that it was for users who are disabled.