fix: error handler text/html output

package.json

@@ -47,7 +47,6 @@
     "prettier"
   ],
   "devDependencies": {
-    "@faker-js/faker": "^6.0.0-alpha.7",
     "@jest/globals": "^27.5.1",
     "@types/bcryptjs": "^2.4.2",
     "@types/compression": "^1.7.2",
@@ -60,6 +59,7 @@
     "@types/node": "^16.11.12",
     "@types/nodemailer": "^6.4.4",
     "@types/passport-jwt": "^3.0.6",
+    "@types/supertest": "^2.0.11",
     "@types/swagger-jsdoc": "^6.0.1",
     "@types/swagger-ui-express": "^4.1.3",
     "@types/validator": "^13.7.0",
@@ -110,6 +110,7 @@
     "swagger-ui-express": "^4.2.0",
     "validator": "^13.7.0",
     "winston": "^3.3.3",
-    "xss-clean": "^0.1.1"
+    "xss-clean": "^0.1.1",
+    "@faker-js/faker": "^6.0.0-alpha.7"
   }
 }

src/components/auth/auth.controller.ts

@@ -1,15 +1,10 @@
 import httpStatus from 'http-status';
 import { Request, Response } from 'express';
 import catchAsync from '../../utils/catchAsync';
-import { createUser } from '../user/user.service';
+import { registerUser } from '../user/user.service';
 import { generateAuthTokens, generateResetPasswordToken, generateVerifyEmailToken } from '../token/token.service';
 import { loginUserWithEmailAndPassword, logout, refreshAuth, resetPassword, verifyEmail } from './auth.service';
-import {
-  sendAccountCreated,
-  sendResetPasswordEmail,
-  sendSuccessfulRegistration,
-  sendVerificationEmail,
-} from '../email/email.service';
+import { sendAccountCreated, sendResetPasswordEmail, sendVerificationEmail } from '../email/email.service';
 import config from '../../config/config';
 import { AccessAndRefreshTokens } from '../token/token.interfaces';
 
@@ -19,10 +14,8 @@ export const sendTokens = (res: Response, tokens: AccessAndRefreshTokens) => {
 };
 
 export const registerController = catchAsync(async (req: Request, res: Response) => {
-  const user = await createUser(req.body);
+  const user = await registerUser(req.body);
   const tokens = await generateAuthTokens(user);
-  const verifyEmailToken = await generateVerifyEmailToken(user);
-  await sendSuccessfulRegistration(user.email, verifyEmailToken, user.name);
   res.status(httpStatus.CREATED).send({ user, tokens });
 });
 

src/components/auth/auth.middleware.ts

@@ -24,7 +24,7 @@ const verifyCallback =
     resolve();
   };
 
-const auth =
+const authMiddleware =
   (...requiredRights: string[]) =>
   async (req: Request, res: Response, next: NextFunction) =>
     new Promise<void>((resolve, reject) => {
@@ -33,4 +33,4 @@ const auth =
       .then(() => next())
       .catch((err) => next(err));
 
-export default auth;
+export default authMiddleware;

src/components/auth/auth.service.ts

@@ -1,4 +1,5 @@
 import httpStatus from 'http-status';
+import mongoose from 'mongoose';
 import Token from '../token/token.model';
 import ApiError from '../errors/ApiError';
 import tokenTypes from '../token/token.types';
@@ -42,7 +43,7 @@ export const logout = async (refreshToken: string): Promise<void> => {
 export const refreshAuth = async (refreshToken: string): Promise<AccessAndRefreshTokens> => {
   try {
     const refreshTokenDoc = await verifyToken(refreshToken, tokenTypes.REFRESH);
-    const user = await getUserById(refreshTokenDoc.user);
+    const user = await getUserById(new mongoose.Types.ObjectId(refreshTokenDoc.user));
     if (!user) {
       throw new Error();
     }
@@ -62,7 +63,7 @@ export const refreshAuth = async (refreshToken: string): Promise<AccessAndRefres
 export const resetPassword = async (resetPasswordToken: any, newPassword: string): Promise<void> => {
   try {
     const resetPasswordTokenDoc = await verifyToken(resetPasswordToken, tokenTypes.RESET_PASSWORD);
-    const user = await getUserById(resetPasswordTokenDoc.user);
+    const user = await getUserById(new mongoose.Types.ObjectId(resetPasswordTokenDoc.user));
     if (!user) {
       throw new Error();
     }
@@ -81,7 +82,7 @@ export const resetPassword = async (resetPasswordToken: any, newPassword: string
 export const verifyEmail = async (verifyEmailToken: any): Promise<IUserDoc | null> => {
   try {
     const verifyEmailTokenDoc = await verifyToken(verifyEmailToken, tokenTypes.VERIFY_EMAIL);
-    const user = await getUserById(verifyEmailTokenDoc.user);
+    const user = await getUserById(new mongoose.Types.ObjectId(verifyEmailTokenDoc.user));
     if (!user) {
       throw new Error();
     }