fix: add env variables to node.js.yml

saisilinus · Apr 8, 2022 · 7bd7c28 · 7bd7c28
1 parent a34e428
commit 7bd7c28
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 29 deletions.
diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml
@@ -10,6 +10,15 @@ on:
   pull_request:
     branches: [ master ]
 
+env:
+  PORT: 3000
+  MONGODB_URL: mongodb://127.0.0.1:27017/node-ts-boilerplate
+  JWT_SECRET: thisisasamplesecret
+  JWT_ACCESS_EXPIRATION_MINUTES: 30
+  JWT_REFRESH_EXPIRATION_DAYS: 30
+  JWT_RESET_PASSWORD_EXPIRATION_MINUTES: 10
+  JWT_VERIFY_EMAIL_EXPIRATION_MINUTES: 10
+
 jobs:
   build:
 

diff --git a/dist/app.js b/dist/app.js
@@ -5,7 +5,6 @@ import ExpressMongoSanitize from 'express-mongo-sanitize';
 import compression from 'compression';
 import cors from 'cors';
 import passport from 'passport';
-import cookieParser from 'cookie-parser';
 import httpStatus from 'http-status';
 import config from './config/config';
 import { morgan } from './modules/logger';
@@ -21,8 +20,6 @@ if (config.env !== 'test') {
 }
 // set security HTTP headers
 app.use(helmet());
-// use cookie parser for jwt
-app.use(cookieParser(config.cookies.secret));
 // enable cors
 app.use(cors());
 app.options('*', cors());

diff --git a/dist/config/config.js b/dist/config/config.js
@@ -20,7 +20,6 @@ const envVarsSchema = Joi.object()
     SMTP_USERNAME: Joi.string().description('username for email server'),
     SMTP_PASSWORD: Joi.string().description('password for email server'),
     EMAIL_FROM: Joi.string().description('the from field in the emails sent by the app'),
-    COOKIE_SECRET: Joi.string().required().description('Cookie secret key'),
   })
   .unknown();
 const { value: envVars, error } = envVarsSchema.prefs({ errors: { label: 'key' } }).validate(process.env);
@@ -50,9 +49,6 @@ const config = {
       signed: true,
     },
   },
-  cookies: {
-    secret: envVars.COOKIE_SECRET,
-  },
   email: {
     smtp: {
       host: envVars.SMTP_HOST,

diff --git a/package.json b/package.json
@@ -94,7 +94,6 @@
     "@faker-js/faker": "^6.0.0-alpha.7",
     "bcryptjs": "^2.4.3",
     "compression": "^1.7.4",
-    "cookie-parser": "^1.4.6",
     "cors": "^2.8.5",
     "cross-env": "^7.0.3",
     "dotenv": "^10.0.0",

diff --git a/src/app.ts b/src/app.ts
@@ -5,7 +5,6 @@ import ExpressMongoSanitize from 'express-mongo-sanitize';
 import compression from 'compression';
 import cors from 'cors';
 import passport from 'passport';
-import cookieParser from 'cookie-parser';
 import httpStatus from 'http-status';
 import config from './config/config';
 import { morgan } from './modules/logger';
@@ -24,9 +23,6 @@ if (config.env !== 'test') {
 // set security HTTP headers
 app.use(helmet());
 
-// use cookie parser for jwt
-app.use(cookieParser(config.cookies.secret));
-
 // enable cors
 app.use(cors());
 app.options('*', cors());

diff --git a/src/config/config.ts b/src/config/config.ts
@@ -20,7 +20,6 @@ const envVarsSchema = Joi.object()
     SMTP_USERNAME: Joi.string().description('username for email server'),
     SMTP_PASSWORD: Joi.string().description('password for email server'),
     EMAIL_FROM: Joi.string().description('the from field in the emails sent by the app'),
-    COOKIE_SECRET: Joi.string().required().description('Cookie secret key'),
   })
   .unknown();
 
@@ -53,9 +52,6 @@ const config = {
       signed: true,
     },
   },
-  cookies: {
-    secret: envVars.COOKIE_SECRET,
-  },
   email: {
     smtp: {
       host: envVars.SMTP_HOST,

diff --git a/yarn.lock b/yarn.lock
@@ -2245,14 +2245,6 @@ convert-source-map@^1.4.0, convert-source-map@^1.6.0, convert-source-map@^1.7.0:
   dependencies:
     safe-buffer "~5.1.1"
 
-cookie-parser@^1.4.6:
-  version "1.4.6"
-  resolved "https://registry.npmjs.org/cookie-parser/-/cookie-parser-1.4.6.tgz"
-  integrity sha512-z3IzaNjdwUC2olLIB5/ITd0/setiaFMLYiZJle7xg5Fe9KWAceil7xszYfHHBtDFYLSgJduS2Ty0P1uJdPDJeA==
-  dependencies:
-    cookie "0.4.1"
-    cookie-signature "1.0.6"
-
 cookie-signature@1.0.6:
   version "1.0.6"
   resolved "https://registry.npmjs.org/cookie-signature/-/cookie-signature-1.0.6.tgz"
@@ -2263,11 +2255,6 @@ cookie@0.4.0:
   resolved "https://registry.npmjs.org/cookie/-/cookie-0.4.0.tgz"
   integrity sha512-+Hp8fLp57wnUSt0tY0tHEXh4voZRDnoIrZPqlo3DPiI4y9lwg/jqx+1Om94/W6ZaPDOUbnjOt/99w66zk+l1Xg==
 
-cookie@0.4.1:
-  version "0.4.1"
-  resolved "https://registry.npmjs.org/cookie/-/cookie-0.4.1.tgz"
-  integrity sha512-ZwrFkGJxUR3EIoXtO+yVE69Eb7KlixbaeAWfBQB9vVsNn/o+Yw69gBWSSDK825hQNdN+wF8zELf3dFNl/kxkUA==
-
 cookiejar@^2.1.2:
   version "2.1.3"
   resolved "https://registry.npmjs.org/cookiejar/-/cookiejar-2.1.3.tgz"