Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line 144 of code #1

Open
mengxiangming opened this issue Sep 17, 2019 · 4 comments
Open

Line 144 of code #1

mengxiangming opened this issue Sep 17, 2019 · 4 comments

Comments

@mengxiangming
Copy link

Hi, thanks for sharing the code and I have one question about the line 144 of Bi-Real-Net where self.tanh1 is defined but not used anywhere else. Is there something missing? Thanks.

@sajaddarabi
Copy link
Owner

Hi,

self.tanh1 is really a placeholder that could be used as an activation after the first bn1, though I believe in the original birealnet they don't do so.

I'll try to push the complete training code this weekend or the following week once I have some headroom :)

@mengxiangming
Copy link
Author

mengxiangming commented Sep 17, 2019 via email

@sajaddarabi
Copy link
Owner

sajaddarabi commented Sep 17, 2019

Hi Xiang Ming,

Yes, it should converge properly if you use the correct settings.

I've added pretrained weights (which should probably save you a week..), and accuracy curves in README.md.

The top-1 accuracies I get for the fp model at epoch 120 for bireal18 and bireal34 are 67.928% and 70.246% respectively.

As for the code, I currently don't have access to my laptop. I'll try to push it end of this week or early next week.

Hope this helps :)
Sajad

@mengxiangming
Copy link
Author

mengxiangming commented Sep 18, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants