Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove need for OPTIONS pre-flight #36

Closed
mish15 opened this issue Jan 8, 2019 · 1 comment · Fixed by #37
Closed

Remove need for OPTIONS pre-flight #36

mish15 opened this issue Jan 8, 2019 · 1 comment · Fixed by #37
Labels
enhancement

Comments

@mish15
Copy link
Member

mish15 commented Jan 8, 2019

This causes a delay on the first key-press for a user. See https://stackoverflow.com/questions/29954037/why-is-an-options-request-sent-and-can-i-disable-it

Likely cause we send the Content-Type: application/json header, which is not allowed. Only the following are allowed for the Content-Type header:

  • application/x-www-form-urlencoded
  • multipart/form-data
  • text/plain
benhinchley pushed a commit that referenced this issue Aug 13, 2019
rewrite
a471ea6 
fixes #36
@benhinchley benhinchley mentioned this issue Aug 13, 2019
Merged
benhinchley pushed a commit that referenced this issue Aug 28, 2019
rewrite
02419f4 
fixes #36
@benhinchley
Copy link
Member

This has been resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updates and Upgrades sajari/sdk-js
2 participants
@mish15 @benhinchley