Added support for gensim-encoded models. #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dhowden Wow thanks for the fast responses! Unfortunately, since the newlines aren't present the last line won't have a newline at the end and so this attempts to read past the end of the file. Does fixing this in the gensim library seem to be the better thing to do? I could open a PR over there. |
dhowden
force-pushed
the
gensim-model-support
branch
from
182a3f3
to
8cb7342
Compare
|
@akdh Wow it's been a while - apologies! I've just pushed another commit which handles the error with the last value. Merging this into master, it should work for you now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2