task: error codes

src/httpClient.ts

@@ -1,3 +1,5 @@
+import { convert } from '@feathersjs/errors';
+
 export interface httpClientOptions {
   hostname: string;
   username?: string;
@@ -38,7 +40,9 @@ const request = async (options: RequestOptions) => {
 
     if (!response.ok) {
       logger({ statusCode: response.status, statusText: response.statusText });
-      throw new Error(`${response.status} ${response.statusText}`);
+      const error = new Error(`${response.status} ${response.statusText}`);
+      error.name = `${response.status}`;
+      throw convert(error);
     }
 
     return response.json();

test/client.test.ts

@@ -3,6 +3,7 @@ import assert from 'assert';
 import { SolrService } from '../src';
 import { httpClient } from '../src/httpClient';
 import { createCore, deleteCore, addSchema, deleteSchema } from './seed';
+import { FeathersError } from '@feathersjs/errors';
 
 const options = {
   host: 'http://localhost:8983/solr',
@@ -60,7 +61,7 @@ describe('client', () => {
         await Client.get('/solr/notexist', {})
         throw new Error(`Expected an error and didn't get one!`)
       } catch (error: unknown) {
-        return assert.equal((error as Error).message, '404 Not Found')
+        return assert.equal((error as FeathersError).code, 404)
       }
     });
 
@@ -93,7 +94,7 @@ describe('client', () => {
         });
         throw new Error(`Expected an error and didn't get one!`)
       } catch (error: unknown) {
-        return assert.equal((error as Error).message, '500 Server Error')
+        return assert.equal((error as FeathersError).code, 500)
       }
     });
   });