Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAK-48460 Citations delete a resource containing a citations list #11457

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

SAK-48460 Citations delete a resource containing a citations list #11457

wants to merge 8 commits into from

Conversation

jkjanetschek
Copy link
Contributor

No description provided.

ern
ern requested changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@ern ern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having kernel depend on a component is generally not a good idea.
I would recommend another approach.

kernel/kernel-impl/pom.xml Show resolved Hide resolved
@ern ern changed the title SAK-48460 hardDelete of resource containing a citationsList SAK-48460 Citations delete a resource containing a citations list Apr 13, 2023
@jkjanetschek jkjanetschek marked this pull request as draft April 26, 2023 14:53
@jkjanetschek
Copy link
Contributor Author

This version does implement Observer in BaseCitationService, which handles an event posted by ContentHosting.
But it seems that the dependeny injecton of eventTrackingService into BaseCitationService does not work. I do currently not know why.
Has anybody any suggestion/comments for this and the implementation?

@jkjanetschek jkjanetschek requested a review from ern May 3, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ern ern Awaiting requested review from ern

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jkjanetschek @ern