Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAK-45738 SiteStats wicket9 upgrade #12606

Merged
merged 2 commits into from
May 28, 2024

Conversation

ottenhoff
Copy link
Contributor

No description provided.

@ern ern marked this pull request as draft May 15, 2024 17:29
@ottenhoff ottenhoff changed the title WIP SiteStats wicket9 SAK-45738 SiteStats wicket9 upgrade May 21, 2024
@ottenhoff ottenhoff marked this pull request as ready for review May 21, 2024 16:21
tools.add(new SelectOption("option", new ToolModel(toolInfo)));
}
}
// add tools
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacing

users.add(opt);
}
}
for (String userId : siteUsers) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacing

@jesusmmp
Copy link
Contributor

Looks good but a lot of spacing issues.

@ottenhoff ottenhoff merged commit 2673b5f into sakaiproject:master May 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants