Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAK-29089 - Add some better styling for blockquote tag #204

Merged
merged 2 commits into from Feb 25, 2015

Conversation

jonespm
Copy link
Contributor

@jonespm jonespm commented Feb 19, 2015

No description provided.

@ern
Copy link
Contributor

ern commented Feb 23, 2015

Looks good here!

Conflicts:
	reference/library/src/webapp/skin/tool_base.css
@buckett
Copy link
Member

buckett commented Feb 24, 2015

LGTM.

Out of interest is this targeting any particular existing use of blockquote?

@jonespm
Copy link
Contributor Author

jonespm commented Feb 24, 2015

In the CKEditor there's a button for blockquote. We had some users who happened to click it and when they saved it didn't look like anything happened. The tag saved but there was just no special style applied for this tag. So it would update the formatting for those had used this in the editor in the past or future.

jonespm added a commit that referenced this pull request Feb 25, 2015
SAK-29089 - Add some better styling for blockquote tag
@jonespm jonespm merged commit d8ede9b into sakaiproject:master Feb 25, 2015
@jonespm jonespm deleted the SAK-29089 branch February 25, 2015 14:38
steveswinsburg added a commit to steveswinsburg/sakai that referenced this pull request Dec 2, 2015
josecebe added a commit to josecebe/sakai that referenced this pull request Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants