Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAK-42671 Sakai Editor Webcomponent CKEditor 5 #7467

Merged
merged 4 commits into from Nov 4, 2019
Merged

SAK-42671 Sakai Editor Webcomponent CKEditor 5 #7467

merged 4 commits into from Nov 4, 2019

Conversation

ern
Copy link
Contributor

@ern ern commented Oct 21, 2019

No description provided.

accesslint[bot]
accesslint bot suggested changes Oct 21, 2019
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

webcomponents/tool/src/main/frontend/sakai-editor.js Outdated Show resolved Hide resolved
accesslint[bot]
accesslint bot approved these changes Oct 21, 2019
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@sakaiproject sakaiproject deleted a comment Oct 21, 2019
adrianfish
adrianfish requested changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@adrianfish adrianfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few bits and bats

webcomponents/tool/src/main/frontend/sakai-editor.js Outdated Show resolved Hide resolved
webcomponents/tool/src/main/frontend/sakai-editor.js Outdated Show resolved Hide resolved
webcomponents/tool/src/main/frontend/sakai-editor.js Outdated Show resolved Hide resolved
webcomponents/tool/src/main/frontend/sakai-editor.js Outdated Show resolved Hide resolved
webcomponents/tool/src/main/frontend/sakai-editor.js Outdated Show resolved Hide resolved
webcomponents/tool/src/main/frontend/sakai-editor.js Outdated Show resolved Hide resolved
@mpellicer
Copy link
Contributor

Should we set this as a draft or WIP?

@sakaiproject sakaiproject deleted a comment Oct 23, 2019
@sakaiproject sakaiproject deleted a comment Oct 23, 2019
@ern ern requested a review from adrianfish November 4, 2019 17:42
adrianfish
adrianfish approved these changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@adrianfish adrianfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@ern ern merged commit ec47de1 into sakaiproject:master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@profmikegreene profmikegreene profmikegreene left review comments

@adrianfish adrianfish adrianfish approved these changes

@accesslint accesslint[bot] accesslint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@ern @mpellicer @adrianfish @profmikegreene