Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shadow elevation should not be limited if a project's minSdk is 31 or above #43

Closed
saket opened this issue Sep 29, 2023 · 1 comment
Closed

Shadow elevation should not be limited if a project's minSdk is 31 or above #43

saket opened this issue Sep 29, 2023 · 1 comment

Comments

@saket
Copy link
Owner

saket commented Sep 29, 2023

cascade copies material3's behavior of limiting elevation to 8dp. This was done to workaround a bug on systems older than API level 31 where any content under drop shadows weren't visible to screen readers (source).

cascade/cascade-compose/src/main/java/me/saket/cascade/Cascade.kt

Line 202 in f3840d7

shadowElevation = shadowElevation.coerceAtMost(8.dp),

This is unfortunate because larger shadows look definitely a lot nicer. cascade should read the project's minSdk and allow elevations > 8.dp on API level 31 and above.
saket added a commit that referenced this issue Oct 4, 2023
@saket
#43: Avoid limiting drop shadows to 8dp if minSdk >= 31
92618b5
@saket
Copy link
Owner Author

saket commented Oct 8, 2023

Done by 92618b5

@saket saket closed this as completed Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@saket