Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Dim background #18

Open
wants to merge 10 commits into
base: trunk
Choose a base branch
from
Open

Feature: Dim background #18

wants to merge 10 commits into from

Commits on Oct 18, 2020

  1. Added support for adding overlay below the PopupWindow

    @rohithThammaiah
    rohithThammaiah committed Oct 18, 2020
    Copy the full SHA
    070a99b View commit details
    Browse the repository at this point in the history

  2. Added overlayColor in sample app

    @rohithThammaiah
    rohithThammaiah committed Oct 18, 2020
    Copy the full SHA
    0e84ae0 View commit details
    Browse the repository at this point in the history

  3. Animating overlay visibility using ObjectAnimator

    @rohithThammaiah
    rohithThammaiah committed Oct 18, 2020
    Copy the full SHA
    893c130 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2020

  1. Using anchor.rootView to add an overlay instead of relying on activ… 

    …ity context for `decorView`
    @rohithThammaiah
    rohithThammaiah committed Oct 23, 2020
    Copy the full SHA
    5f3f37f View commit details
    Browse the repository at this point in the history

  2. Removed default constructor params from View initiallization

    @rohithThammaiah
    rohithThammaiah committed Oct 23, 2020
    Copy the full SHA
    63a8424 View commit details
    Browse the repository at this point in the history

  3. Using View.animate() instead of ObjectAnimator to animate overlay… 

    … visibility changes
    @rohithThammaiah
    rohithThammaiah committed Oct 23, 2020
    Copy the full SHA
    9941961 View commit details
    Browse the repository at this point in the history

  4. Avoided lazy initialisation of overlayColor resource

    @rohithThammaiah
    rohithThammaiah committed Oct 23, 2020
    Copy the full SHA
    76307c0 View commit details
    Browse the repository at this point in the history

  5. Renamed overlayColor to backgroundDimColor

    @rohithThammaiah
    rohithThammaiah committed Oct 23, 2020
    Copy the full SHA
    669c09b View commit details
    Browse the repository at this point in the history

  6. Reusing interpolator & duration from PopupWindow's enter & exit tra… 

    …nsitions
    @rohithThammaiah
    rohithThammaiah committed Oct 23, 2020
    Copy the full SHA
    c6f76db View commit details
    Browse the repository at this point in the history

  7. Extracted applying dim to a separate function called `applyBackground… 

    …Dim`
    @rohithThammaiah
    rohithThammaiah committed Oct 23, 2020
    Copy the full SHA
    3625a53 View commit details
    Browse the repository at this point in the history