Draw background only on action box #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Couldn't run/check paparazzi tests because it's not working on my machine, throwing this error: Seems like related to cashapp/paparazzi#375 |
This was referenced May 1, 2022
|
|
saket
approved these changes
May 5, 2022
| @@ -51,7 +51,7 @@ fun SwipeableActionsBox( | |||
| startActions: List<SwipeAction> = emptyList(), | |||
| endActions: List<SwipeAction> = emptyList(), | |||
| swipeThreshold: Dp = 40.dp, | |||
| backgroundUntilSwipeThreshold: Color = Color.DarkGray, | |||
| backgroundUntilSwipeThreshold: Color = Color.Transparent, | |||
There was a problem hiding this comment.
I'd leave this as-is, mostly because this would be a breaking change for existing usages.
|
Uhhh my changes aren't showing up on your branch. Trying again… |
saket
force-pushed
the
berkeli/draw-over-action-box-only
branch
3 times, most recently
from
e13c2ac
to
a460e89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is best implementation but it's working.
Resolves #4
Also fixes #2