Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower minSdk to 23 #16

Merged
merged 7 commits into from
May 28, 2023
Merged

Lower minSdk to 23 #16

merged 7 commits into from
May 28, 2023

Conversation

saket
Copy link
Owner

@saket saket commented May 17, 2023

Fixes #14

@saket saket mentioned this pull request May 17, 2023
Closed
@emulator-wtf
Copy link

emulator-wtf bot commented May 28, 2023

:zoomable-image:core - Tests were flaky!

✅ 119 passed / ⚠️ 1 flaky

First failure encountered:

me.saket.telephoto.zoomable.ZoomableImageTest.various_image_sizes_and_alignments[TopCenter,Crop,SmallerThanLayoutSize,WrapContent,SubSamplingEnabled] click for details

androidx.compose.ui.test.ComposeTimeoutException: Condition still not satisfied after 5000 ms
at androidx.compose.ui.test.AndroidComposeUiTestEnvironment$AndroidComposeUiTestImpl.waitUntil(ComposeUiTest.android.kt:448)
at androidx.compose.ui.test.junit4.AndroidComposeTestRule.waitUntil(AndroidComposeTestRule.android.kt:306)
at me.saket.telephoto.util.WaitUntilKt.waitUntil-8Mi8wO0(waitUntil.kt:7)
at me.saket.telephoto.zoomable.ZoomableImageTest.various_image_sizes_and_alignments(ZoomableImageTest.kt:214)

@saket saket merged commit fb24ac5 into trunk May 28, 2023
2 checks passed
@saket saket deleted the saket/may18/min-sdk-23 branch May 28, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support lower sdk version
1 participant
@saket