-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiplatform: Port :zoomable module to Compose Multiplatform #17
Conversation
@DSteve595 can you rebase this PR? |
:zoomable-image:core - Tests were flaky! ✅ 119 passed / First failure encountered:
There were more failures, click for details |
@saket Done! Is that flaky test from my PR? |
Awesome! I don't think the flake was introduced here. I've been dealing with flakes for a while. They're proving really hard to solve. |
Huh, emulator-wtf is now saying one test failed despite posting a success message earlier. I'll rerun the tests. cc @madisp |
Thanks Steve! |
@saket hmm, I think this can happen if you have multiple modules and one of them succeeds at first (we don't know beforehand how many different module tests there can be so we can't really link them together like that) and another one fails later. Ideally I'd like to figure out how to show GitHub checks for PR-triggered builds as well, that would have a stronger indication (you'd see some tests as running/queued first and you could make some set of checks as required via branch protection rules). |
@madisp Got it, thanks for explaining! |
#9
This adds a convention plugin for modules using Kotlin Multiplatform + Jetbrains Compose, and migrates the :zoomable module to use it.
Things to note:
-Xjvm-default=all
properly.I migrated tests from Truth toNow using assertk.kotlin.test
, but that API is pretty basic.(This is a re-open of #10, which got lost when something weird happened to my fork)