Fix Image becoming unclickable after using double tap zoom #20
Conversation
There was a problem hiding this comment.
Thank you @K1rakishou! Let's move the test to its correct location and this should be good to go.
| private val composableTag = "ZoomableAsyncImage" | ||
|
|
||
| @Test | ||
| fun must_still_be_clickable_after_double_tap_zooming() = runTest { |
There was a problem hiding this comment.
Can you remove this test and move the assertions ZoomableImageTest which already has a test for click listeners?
There was a problem hiding this comment.
That'll also remove the need for having a base test class. Base classes aren't great 🙂.
| state.handleDoubleTapZoomTo(centroid = centroid) | ||
| } finally { | ||
| isQuickZooming = false | ||
| } |
|
Can you rebase on |
saket
force-pushed
the
(#18)-fix-image-becoming-unclickable
branch
from
d64cfe7
to
8acff3d
Compare
Fix Zoomable not resetting isQuickZooming to false after calling handleDoubleTapZoomTo() because it may throw CancellationException which wasn't handled. Unzoom back and check that the image is still clickable. Post review fixes. - Move click tests to click_listeners_work(). - Revert CoilImageSourceTest. - Remove BaseTest and ClicksTest. Revert this too.
saket
force-pushed
the
(#18)-fix-image-becoming-unclickable
branch
from
8acff3d
to
8b7815f
Compare
|
:zoomable-image:sub-sampling-image - Tests were flaky! ✅ 22 passed / First failure encountered:
|
Fixes #18