Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle all links #177

Merged
merged 18 commits into from
Feb 23, 2023
Merged

Handle all links #177

merged 18 commits into from
Feb 23, 2023

Conversation

saketkc
Copy link
Owner

@saketkc saketkc commented Feb 23, 2023

This PR adds support for handling all links outputted by the NCBI API instead of relying on partial matches to AWS/GCP.

@saketkc
Copy link
Owner Author

saketkc commented Feb 23, 2023

Closes #170

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Base: 58.70% // Head: 59.04% // Increases project coverage by +0.33% 🎉

Coverage data is based on head (b496f6e) compared to base (18757f1).
Patch coverage: 91.02% of modified lines in pull request are covered.

❗ Current head b496f6e differs from pull request most recent head 250766d. Consider uploading reports for the commit 250766d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #177      +/-   ##
==========================================
+ Coverage   58.70%   59.04%   +0.33%     
==========================================
  Files           8        8              
  Lines        1821     1836      +15     
==========================================
+ Hits         1069     1084      +15     
  Misses        752      752              
Impacted Files Coverage Δ
pysradb/cli.py 0.00% <ø> (ø)
pysradb/sraweb.py 82.88% <90.90%> (+0.47%) ⬆️
pysradb/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@saketkc saketkc merged commit d913880 into master Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant