-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #26 test cases and uri code updated #31
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
33920be
Solves Issue_26 using uri filenames.
c5c29c4
Merge remote-tracking branch 'upstream/master' into issue_7
b7be4d4
Issue #26 test_case added
a21b62d
Issue #26 test_case added updated
7d9db56
test cases updated
f781f1d
test cases updated
952a5c5
test_sradb.py changes
a26a89a
updated test_not_valid_file() in test_sradb.py
DaasDaham ec87aaa
black
66e2215
merge
783e017
reformatted with black
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
"""Tests for sradb.py | ||
""" | ||
|
||
import os | ||
import pytest | ||
from pysradb import SRAdb | ||
from pysradb.filter_attrs import guess_cell_type, guess_tissue_type, guess_strain_type | ||
from sqlite3 import OperationalError | ||
|
||
|
||
def test_not_valid_file(): | ||
"""Test to check for error if file is either not | ||
present or not a valid sqlite file""" | ||
path = "SRAmetadb.sqlite" | ||
try: | ||
db = SRAdb(path) | ||
except SystemExit: | ||
assert os.path.isfile(path) == False | ||
except OperationalError: | ||
assert True |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you help me understand which case would a
SystemExit
error arise?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case if a file does not exist,
sqlite3.connect()
(line 27) in basedb.py will throw an Operational error which will be caught inexcept:
statement (line 152 in sradb.py) which will eventually lead to asys.exit(1)
on line 157 in sradb.py. This is theSystemExit
that my function would catch.