Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SRR to GSM #34

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Fix SRR to GSM #34

merged 1 commit into from
Mar 10, 2020

Conversation

saketkc
Copy link
Owner

@saketkc saketkc commented Mar 10, 2020

Closes #33
Fixes #24

Closes #33
Fixes #24
@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

Merging #34 into master will increase coverage by 1.7%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #34     +/-   ##
=========================================
+ Coverage   39.02%   40.72%   +1.7%     
=========================================
  Files           5        5             
  Lines         984      987      +3     
=========================================
+ Hits          384      402     +18     
+ Misses        600      585     -15
Impacted Files Coverage Δ
pysradb/cli.py 0% <0%> (ø) ⬆️
pysradb/sraweb.py 85.34% <100%> (+3.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update babd8f6...96c439f. Read the comment docs.

@saketkc saketkc merged commit 36a5717 into master Mar 10, 2020
@saketkc saketkc deleted the fix_24 branch March 10, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyerror in srr_to_gsm function in sraweb.py
1 participant