Fix generator expression for binary targets in compile definitions #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Affected generator expressions are replaced through the static variable value and a corresponding STREQUAL generator expression. * Closes sakra#135
Naios
force-pushed
the
binary_gen_expressions
branch
from
780a3a9
to
16121f2
Compare
ddemidov
added a commit
to KratosMultiphysics/Kratos
that referenced
this pull request
Jan 23, 2019
|
Tested successfully in KratosMultiphysics/Kratos#3831. |
ddemidov
added a commit
to KratosMultiphysics/Kratos
that referenced
this pull request
Feb 8, 2019
|
Works for me too! Thanks! |
bilke
added a commit
to bilke/cmake-modules
that referenced
this pull request
Mar 27, 2020
pandreidoru
added a commit
to pandreidoru/cmake_googletest_gcov
that referenced
this pull request
May 14, 2020
0503702 [cotire] Update with sakra/cotire#155 66fa257 [CodeCoverage ]Added note about best usage practices. 3e03403 Merge pull request #45 from bilke/cleanup 412aadf Updated README f9fe48f Removed old cmake modules. a146ac4 Removed old cmake modules and licensing scripts. 4a69cf9 Merge pull request #44 from ferdnyc/coverage-commands 724facc Remove manual escaping in gcovr targets f10f88c CodeCoverage: Use VERBATIM for target commands fadc9ab Merge pull request #42 from apthorpe/master 75ae602 Revised based on review comments 0deb6ef Added gfortran support cf2e087 Merge pull request #41 from ferdnyc/coverage-tweaks2 5367498 Tweak output file handling 0b3d107 Merge pull request #39 from ferdnyc/coverage-tweaks 0194339 Add COVERAGE_EXCLUDES var and EXCLUDE option aa6381e setup_target_for_coverage_lcov: accept NO_DEMANGLE 6920287 Add BASE_DIRECTORY setup argument dd0b7f6 Use full paths in COVERAGE_LCOV_EXCLUDES example 323debd Lowercase function names, add change comment b7aef47 Fix auto-demangling 4069eb3 Clean up output files better on 'make clean' 8141988 Set base directory for lcov runs 855e765 Add automatic demangling to lcov 088cb4e Remove Python detection f14e6e7 Merge pull request #36 from armatusmiles/master fd2bac1 Merge pull request #38 from endJunction/NetCdfOnArchlinux ef1de92 Add netcdf_c++4 library variant used on ArchLinux. e179b7d Remove unnecessary --coverage flag 5893e3e Added simplified FindNetCDF.cmake for Conan package. 0068e16 Fixed CVODE_INCLUDE_DIRS. 9d5f5fa Use FindPython module in CodeCoverage.cmake. 72d804c Removed -O0 flag from CodeCoverage.cmake 819ad94 Removed DoxygenTargets. Use FindDoxygen.cmake instead. f4b0a05 Removed FindNetCDF.cmake. 000c61b Removed outdated FindEigen3.cmake. 34b8106 Merge pull request #34 from mdadams/master d339e7a Added LCOV_ARGS and GENHTML_ARGS options to the SETUP_TARGET_FOR_COVERAGE_LCOV function. These options allow additional flags to be specified to the lcov and genhtml programs when invoked. For example, the LCOV_ARGS and GENHTML_ARGS might be set to "-rc lcov_branch_coverage=1" and "--branch-coverage", respectively, in order to ensure that branch-coverage information is generated. git-subtree-dir: lib/cmake-modules git-subtree-split: 0503702f2ef733aa8f6a0c2015db89b085c5ac57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
variable value and a corresponding STREQUAL generator expression.
This needs some proper testing!